-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media: Skip video optimization based on criteria #11454
Conversation
Size Change: +905 B (0%) Total Size: 2.65 MB
ℹ️ View Unchanged
|
Plugin builds for 627a736 are ready 🛎️!
|
packages/story-editor/src/app/media/utils/useMediaUploadQueue/index.js
Outdated
Show resolved
Hide resolved
packages/story-editor/src/components/library/panes/media/common/innerElement.js
Show resolved
Hide resolved
packages/story-editor/src/app/media/utils/useMediaUploadQueue/constants.js
Show resolved
Hide resolved
I am not longer seeing progress bars on uploading items :( See #11454 (comment) |
I am seeing the poster generation hanging. Screen.Recording.2022-07-14.at.11.57.17.movI believe this is happening because poster generation is trying to happen on blob url. Not sure why this is happening. |
This seems to be happening on main as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first start. I think we have more to do here in future PRs.
@spacedmonkey @swissspidy I still see the "Video optimization" message when I upload a video that is a mp4 file, 3.97MB, 720x1280. The video that I am uploading is the second one. The first is to show that the message is still being displayed. |
@felipebochehin87 Good catch! There was some incorrect comparison being used ("<" instead of "<="). However, your video also has a frame rate of only 20 FPS, whereas the recommendation is 24+ FPS, which is why your video is still being optimized. So that is still expected. Apologies for not updating the instructions accordingly. |
Oh thanks @swissspidy! I'll retest right now :) |
@swissspidy I uploaded the video below and also got the message: This video is 1280x720, 120 FPS, 2.12MB. Am I missing anything else? |
@felipebochehin87 Please try again now :-) My fix wasn't uploaded to the QA environment yet when I wrote my comment. But now it's updated there and the video is uploading without optimization. |
Context
We want to avoid needlessly running video optimization on videos that are already in very good shape, for example when the creator has manually optimized videos before upload.
The aim is to improve overall user experience and performance during uploads.
Summary
Relevant Technical Choices
Uses mediainfo.js to get detailed information about codecs, file size, frame rate, etc.
For the start, small videos (< 5MB), with either MP4 or WEBM type and max dimensions of 720x1280, will be automatically marked as optimized.
To-do
User-facing changes
No visual changes per se, but when uploading smaller videos fitting the criteria they will not be optimized by default anymore.
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZ
label to the PRFixes #11405