-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Ensure tooltips consistently show tails (#11304) #11543
Merged
mflorida
merged 1 commit into
main
from
fix/11304-floating-menu-tooltip-inconsistencies
May 27, 2022
Merged
Editor: Ensure tooltips consistently show tails (#11304) #11543
mflorida
merged 1 commit into
main
from
fix/11304-floating-menu-tooltip-inconsistencies
May 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mflorida
force-pushed
the
fix/11304-floating-menu-tooltip-inconsistencies
branch
2 times, most recently
from
May 23, 2022 22:08
5786336
to
b69b4c0
Compare
mflorida
force-pushed
the
fix/11304-floating-menu-tooltip-inconsistencies
branch
from
May 24, 2022 14:53
b69b4c0
to
6195050
Compare
Size Change: +4 B (0%) Total Size: 2.61 MB ℹ️ View Unchanged
|
sblinde
previously approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐝
Super simple fix! Nice
Plugin builds for 8edff61 are ready 🛎️!
|
mflorida
added
Pod: Pea
Type: Bug
Something isn't working
Group: Floating Menu
Floating menu bar on the canvas
and removed
Type: Bug
Something isn't working
labels
May 24, 2022
mwritter
previously approved these changes
May 26, 2022
mflorida
force-pushed
the
fix/11304-floating-menu-tooltip-inconsistencies
branch
from
May 26, 2022 20:09
6195050
to
8edff61
Compare
sblinde
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Tooltips should be rendered consistently with 'tails'.
Summary
Tooltips in the story editor are now rendered with 'tails' by default.
Relevant Technical Choices
The core
Tooltip
component in the story editor was modified to show tails by default.To-do
None
User-facing changes
tooltip-tails.mov
Testing Instructions
In the story editor, hover over UI elements with tooltips - they should all have 'tails'.
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZ
label to the PRFixes #11304