Dashboard dropdown filter displayed over stories when user scrolls up/down #11632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y on the screen at all times - such as dropdowns
mwritter
added
Type: Bug
|
Size Change: +22 B (0%) Total Size: 2.63 MB ℹ️ View Unchanged
|
|
Plugin builds for 9f54834 are ready 🛎️!
|
mwritter
changed the title
mflorida
approved these changes
Jun 6, 2022
It should be for this particular instance, adding more 'override' props will not be sustainable though. I do think if more issues with the dropdown popup combo crop up we will need to refactor the dropdown to work without the popup. |
Makes sense. Although this kind of dropdown needs to 'pop up' on top of all other content, it's a completely different type of component and should be able to live its best life. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Keep dropdown stationary, to keep the dropdown options from moving with user scroll or window resize.
Summary
Adds a property to the Popup component to use x and y offset based on anchorRect, instead of using max offsets.
Relevant Technical Choices
The underlying issue comes from the tight integration between the popup component and the dropdown component. I opted to add a new property here to let the popup component know that this 'popup' does not need move away from the anchorRect while scrolling. A bigger code change to separate the popup and dropdown components is probably going to be necessary if the functionality continues to differ.
To-do
✔️ PR #11625 will need to be updated to add this property to the new taxonomy filters.
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
On Staging
On Branch
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11582