REST API: support filtering taxonomies by hierarchical attribute #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Group: WordPress
8 tasks
spacedmonkey
reviewed
Jun 8, 2022
|
Size Change: +315 B (0%) Total Size: 2.63 MB
ℹ️ View Unchanged
|
spacedmonkey
reviewed
Jun 8, 2022
|
Plugin builds for aea8570 are ready 🛎️!
|
|
This is exactly the same as what I was playing around with locally. I didn't want to have to override this core method like this, but if you want to do this, then I am happy with this change. Add a unit test and I will approve this change. |
|
As you said on the other PR, it's not a big deal as these should be cheap requests. But it felt like something that makes sense and could even be added to core. |
|
@swissspidy This just need php lints to pass and small unit tests and this is good to go. |
|
Sharing for visibility #11436 (comment) |
spacedmonkey
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Based on the discussion at #11625 / #11625 (comment)
Summary
Adds support for filtering hierarchical and flat taxonomies:
/wp-json/web-stories/v1/taxonomies: shows all taxonomies/wp-json/web-stories/v1/taxonomies?hierarchical=true: shows only hierarchical taxonomies/wp-json/web-stories/v1/taxonomies?hierarchical=flat: shows only flat taxonomiesRelevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #