Templates: Remove first page animations #11687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwritter
added
Type: Enhancement
|
Size Change: -6.62 kB (0%) Total Size: 2.62 MB
ℹ️ View Unchanged
|
|
Plugin builds for b1be0ad are ready 🛎️!
|
swissspidy
changed the title
mflorida
approved these changes
Jun 14, 2022
mwritter
deleted the
feature/11648_Remove_First_Page_Animations_From_Templates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Remove all the first page animations on current story templates.
Summary
Sets all templates the first page animations to an empty array.
Relevant Technical Choices
First page animations are not supported by AMP. Web Story templates should not include first page animations.
To-do
User-facing changes
Before:
'First Page Animations' checklist item
Disabled Play button
After:
No 'First Page Animations' checklist item on first page (so no first page animations)
No Play button
Testing Instructions
This PR can be tested by following these steps:
On Staging:
On Branch:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11648