Editor: Fixed right-click in layer panel #11730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially just had to make sure that the reorderable only looks for regular left-clicks and ignores other mouse button clicks.
barklund
commented
Jun 16, 2022
| @@ -36,9 +36,10 @@ function useReordering(onPositionChange, numChildren) { | |||
| const handleStartReordering = useCallback( | |||
| ({ position: currentPos, onStartReordering = () => {} }) => | |||
| (evt) => { | |||
| // Only allow reordering with non-modified click on non-background element. | |||
There was a problem hiding this comment.
The "non-background element" part was left from before the reorderable was generalized out of the layer panel, so this comment does not belong here anymore.
|
Size Change: +26 B (0%) Total Size: 2.62 MB ℹ️ View Unchanged
|
|
Plugin builds for 6ac59c6 are ready 🛎️!
|
|
Should the functionality work for Tested with a mouse and works as expected. |
Oh, that's an excellent question. Then we probably need to detect another key held as well. I'll investigate, thanks! |
Fixed it in 6ac59c6. |
merapi
approved these changes
Jun 17, 2022
timarney
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially just had to make sure that the reorderable only looks for regular left-clicks and ignores other mouse button clicks.
Testing Instructions
This PR can be tested by following these steps:
Checklist
Type: XYZlabel to the PRFixes #11717