Editor: Do not show 'Add animation' quick action on first page #11748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mflorida
added
Pod: Pea
Group: Editing
|
Are the available properties in the |
|
I'm unsure of other reviewers that should be added. |
The full list is here: web-stories-wp/packages/story-editor/src/app/story/storyProvider.js Lines 131 to 173 in dea393a |
mflorida
changed the title
|
Took a look at this, and not sure if it's something with the QA instance (and haven't gotten to check this locally) but wasn't able to see the fix for this. When I added an image to the first page of a Story, I still saw the |
mflorida
force-pushed
the
fix/11602-remove-first-page-add-animation-button
branch
from
1a9d33e
to
fc47b30
Compare
Changes are only available on the QA environment for non-draft PRs and after our bot has left a comment on the PR saying that ZIP files are available for testing. |
|
Size Change: +22 B (0%) Total Size: 2.64 MB ℹ️ View Unchanged
|
|
Plugin builds for a494252 are ready 🛎️!
|
|
^ Now it should work :) |
🤦♀️ That makes total sense, did not realize this was in a draft status. Thank you! |
sblinde
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
🐝
Works great in test, approving.
In the future, if you're expecting review for a pull request, please open the PR regularly and not as a draft. Draft, ideally, should be used for things that need guidance / need to be readily shared with the larger group for conversation.
sblinde
approved these changes
Jun 24, 2022
sblinde
added
the
Type: Enhancement
swissspidy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Since animations cannot be applied to elements on the first page of a story, the 'Add animation' button should not be shown in the 'quick actions' button group.
Summary
The 'Add animation' button will not be rendered on the first page of a story.
Relevant Technical Choices
The
currentPageNumberprop was tracked down and added to the dependency array for the function responsible for building the menu for 'common actions' of foreground elements. The logic for building the button group was changed to add buttons in the order they should appearThe logic for building the
foregroundCommonActionsbutton group was changed to conditionally render the add animation button based on the value of thecurrentPageNumberprop. The logic for rendering the 'reset' button was refactored using the same pattern for consistency.To-do
None.
User-facing changes
Before:
After:
Testing Instructions
Navigate to the first page of a story. Click on an element (that would support animating on the other pages). The 'Add animation' button should not be rendered.
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #11602