-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopping: Support drag & drop from library #11913
Conversation
8712a47
to
da30509
Compare
packages/story-editor/src/components/library/panes/shopping/productList.js
Outdated
Show resolved
Hide resolved
packages/story-editor/src/components/library/panes/shopping/productImage.js
Show resolved
Hide resolved
packages/story-editor/src/components/library/panes/shared/libraryMoveable.js
Outdated
Show resolved
Hide resolved
Size Change: +149 B (0%) Total Size: 2.66 MB
ℹ️ View Unchanged
|
Plugin builds for 60206b8 are ready 🛎️!
|
packages/story-editor/src/components/library/panes/shared/libraryMoveable.js
Outdated
Show resolved
Hide resolved
packages/story-editor/src/components/library/panes/shopping/productImage.js
Show resolved
Hide resolved
Same here |
Added a conditional to fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well.
packages/story-editor/src/components/library/panes/shopping/productImage.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep the tooltip as-is, only on the button. |
packages/story-editor/src/components/library/panes/shopping/product.js
Outdated
Show resolved
Hide resolved
Would be nice to add a Karma test as well for it if possible. web-stories-wp/packages/story-editor/src/components/library/karma/shapes/shapes.karma.js Line 66 in b98f74e
|
Context
Add support for dragging products from the library to the canvas.
Summary
Adds draggable product image
Relevant Technical Choices
To-do
Handle dragging product that already exists on the canvas
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZ
label to the PRFixes #11708