Fix background audio setting & mic-only device support #11939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merapi
commented
Jul 18, 2022
| audio: audioInput && hasAudio ? { deviceId: audioInput } : true, | ||
| video: videoInput && hasVideo ? { deviceId: videoInput } : true, | ||
| audio: hasAudio ? (audioInput ? { deviceId: audioInput } : true) : false, | ||
| video: hasVideo ? (videoInput ? { deviceId: videoInput } : true) : false, |
There was a problem hiding this comment.
For the mic-only device we need to request a device with video: false - we do that when one of the errors occurs.
|
Size Change: +136 B (0%) Total Size: 2.65 MB
ℹ️ View Unchanged
|
|
Plugin builds for 5beefd2 are ready 🛎️!
|
spacedmonkey
approved these changes
Jul 18, 2022
swissspidy
reviewed
Jul 18, 2022
swissspidy
reviewed
Jul 18, 2022
| if ( | ||
| error?.name === 'NotFoundError' || | ||
| error?.name === 'NotReadableError' || | ||
| error?.name === 'OverConstrainedError' |
There was a problem hiding this comment.
IIRC in some browsers this error can occur even when the user has not yet granted permission, so I hope this does not cause any issue in some edge cases. Just noting it here for visibility.
There was a problem hiding this comment.
I haven't seen it anywhere, for me, it always looks like this:
#11939 (comment)
swissspidy
reviewed
Jul 18, 2022
|
This is what it looks like when you don't have a camera, only a mic (double-checked now on W10 Edge/FF/Opera). While the message is correct (No camera found) maybe we can add something about the audio-only option if they grant mic permissions?
|
miina
approved these changes
Jul 19, 2022
|
Audio is added only to the page that is selected. If I clone this page, audio is cloned. If I add a new page, no audio is added to it. And if I have multiple pages and I record an audio, only the selected page has the audio linked to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues with Background Audio:
#11921
#11920
Mic-only support:
If you have a device without a built-in camera please test this PR. You can also attach the camera and check edge cases - I did a bunch of testing with or without resetting the permissions at different stages of the process.
The worst thing that can happen is you start a fresh session (after perms reset) and grant audio-only permission and then attach the camera - you will have to reload the page for the camera permission popup.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #11921
Fixes #11920