Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3P Media: Add category filter for Coverr #12045

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

timarney
Copy link
Contributor

@timarney timarney commented Aug 1, 2022

Context

Adds category filters for Coverr as we already do for Unsplash and Tenor.

Summary

Enable category filters

Screen Shot 2022-08-01 at 5 08 23 AM

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

  1. Browse to the third part media / video tab Coverr
  2. Note categories are available
  3. Click on a category / filter by category

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #8814

@timarney timarney added Group: 3P Media Third-party media provider integrations. Pod: WP Type: Enhancement New feature or improvement of an existing feature labels Aug 1, 2022
@timarney timarney self-assigned this Aug 1, 2022
@timarney timarney marked this pull request as ready for review August 2, 2022 09:59
@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Aug 2, 2022

Plugin builds for afea69a are ready 🛎️!

@timarney timarney merged commit 6506576 into main Aug 8, 2022
@timarney timarney deleted the fix/8814-category-filter-for-coverr branch August 8, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: 3P Media Third-party media provider integrations. Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3P Media: Add category filter for Coverr
3 participants