-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message when Autosave exists #12098
Conversation
9be3c5e
to
f30b9dc
Compare
Plugin builds for 5898d28 are ready 🛎️!
|
packages/story-editor/src/components/autoSaveCheck/autoSaveDialog.js
Outdated
Show resolved
Hide resolved
packages/story-editor/src/components/autoSaveCheck/autoSaveDialog.js
Outdated
Show resolved
Hide resolved
packages/story-editor/src/components/autoSaveCheck/autoSaveDialog.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, but needs the isDraft
check to be removed in AutoSaveHandler
to actually create an autosave with the right format.
Can we do that in this PR?
packages/story-editor/src/components/autoSaveCheck/autoSaveDialog.js
Outdated
Show resolved
Hide resolved
Actually, I suppose #1402 is for doing that. |
…log.js Co-authored-by: Pascal Birchler <pascalb@google.com>
…log.js Co-authored-by: Miina <miina.sikk@gmail.com>
…log.js Co-authored-by: Miina <miina.sikk@gmail.com>
Merging now; QA can be done in #1402 when it becomes actually user-facing. |
Context
Add autosave message to story if available to match the WordPress flow
Summary
Adds autosave message when there's an autosave available.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #3841