Output: optimize fix_malformed_script_link_tags()
regex
#12159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See #12158.
This error with a blank screen can happen when the
preg_replace_callback()
call inHTML::fix_malformed_script_link_tags()
errored and thus an empty content was returned.In my testing this all happened because
$content
even if there was an errorSummary
This PR optimizes the
preg_replace_callback
usage infix_malformed_script_link_tags()
in two ways:$content
if there was an error with the regex replacementRelevant Technical Choices
Removed some dead code
To-do
N/A
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZ
label to the PRFixes #12158