-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert moveable
package to TypeScript
#12169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Infrastructure
Changes impacting testing infrastructure or build tooling
Type: Code Quality
Things that need a refactor, rewrite or just some good old developer ❤️
Package: Moveable
/packages/moveable
labels
Aug 26, 2022
swissspidy
changed the title
[WIP] Convert moveable package to TypeScript
Convert moveable package to TypeScript
Aug 29, 2022
Plugin builds for 4a2f3d2 are ready 🛎️!
|
It seems that the ref inside moveable is a ref to the component instance itself and not to an HTML element or even the manager object.
barklund
reviewed
Sep 1, 2022
swissspidy
changed the title
Convert moveable package to TypeScript
Convert Sep 1, 2022
moveable
package to TypeScript
Last lint error fixed, this should now be ready again. |
Closed
miina
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Package: Moveable
/packages/moveable
Type: Code Quality
Things that need a refactor, rewrite or just some good old developer ❤️
Type: Infrastructure
Changes impacting testing infrastructure or build tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
packages/moveable/src/typings
(see to-do below)To-do
Help needed with these:
OriginalMoveable
packages/moveable/src/typings/*.d.ts
to top-leveltypings/
folder instead. Otherwise it's a bit messy.User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #12088