-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert transform
package to TypeScript
#12202
Conversation
[id: string]: Record<string, unknown> | null; | ||
} | ||
|
||
export interface State { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swissspidy Do you happen to have a good example of creating a context with actions and state that I could check? Not sure exactly how to do this here, had to use type casting which doesn't seem right here. Or is this an example of the useContextSelector
that might still need work (since it's all related to that, and has to match the typing of the context selector)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far I only attempted this in packages/units/src/context.ts
/ packages/units/src/contextProvider.tsx
but yeah it still needs some work to get type support when using useContextSelector
.
This might do the trick though:
https://github.com/GoogleForCreators/web-stories-wp/tree/try/fix-context-state
This way I get type support when doing something like
useUnits(({ state: { pageSize } }) => pageSize);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, not sure if I did something incorrectly but I still have to assign types in the provider for it not to throw errors.
Plugin builds for c1c5ff1 are ready 🛎️!
|
Size Change: +2 B (0%) Total Size: 2.68 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛕
Context
Converts
transform
package to TypeScriptSummary
Relevant Technical Choices
To-do
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #12173