Media: Remove media frame on close #12217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 59a21e5 are ready 🛎️!
|
|
Size Change: -56 B (0%) Total Size: 2.68 MB ℹ️ View Unchanged
|
swissspidy
added
Type: Code Quality
|
Any recommendations on how to verify this change (testing instructions)? Should there be any changes in the DOM? |
No dom change here. It is more about reseting state. One way to test this is to open a wp dialog, search for something and close it. Open again. Discovery this need while looking at this. |
I don't see a difference when doing that. What should be different? |
In my PR this, is no longer required. As removing the the wp.media, means state is reset and no chance of state set in the first instance of using the dialog is not used. |
|
I suppose that explains why there is no difference: there should be none. |
swissspidy
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
While working on #11941. I discovered that wp media instance when the wp media instance is closed. This instance may use memory in the browser and requires resetting. Just use remove method.
See
https://github.com/WordPress/gutenberg/blob/67a652439c3d2f7dd8623d24b0bd12b5aff053f5/packages/media-utils/src/components/media-upload/index.js#L342-L344
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #