Fix preview issues with auto-drafts #12267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Bug
|
Plugin builds for 3223307 are ready 🛎️!
|
|
Size Change: +42 B (0%) Total Size: 2.68 MB ℹ️ View Unchanged
|
|
This feels like a WordPress problem. I don't love hard coding this for all platforms. Why not just fix in php with a filter? |
I tend to agree, but it's a lot more complicated than that. Truly platform-independent status & visibility settings require a lot more work and planning, especially on the JS side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While looking into e2e tests I noticed an issue with the new autosaving mechanism and story previews.
When previewing a story without saving it first, you'd get a 404 because the story was still an
auto-draftand not a regulardraft.Summary
Fixes an issue with stories not being proper
drafts when previewing and thus seeing 404s.Relevant Technical Choices
To-do
User-facing changes
No 404s when previewing a story.
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #