Editor and output: Custom page advancement #12318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barklund
added
Type: Enhancement
|
Plugin builds for bef41f0 are ready 🛎️!
|
|
Size Change: +739 B (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
miina
approved these changes
Sep 15, 2022
packages/story-editor/src/components/panels/shared/generalPageAdvancement.js
Outdated
Show resolved
Hide resolved
added 3 commits
September 15, 2022 15:34
# Conflicts: # includes/Experiments.php
|
Verified this feature via web-story: Custom page advancement#12318 Status:
Scenario: Settings and Defaults
UX Suggestion |
|
Scenario: Overriding and Duration value
|
|
Scenario: Using the page adv settings in Preview & Publish
|
|
Scenario: Corner Cases and Negative Testing
Example - Page Adv Duration is 6 seconds, but embedded video is of 11 sec. Then the page will remain open for 11 sec till video auto plays to completion. However, if the Loop option is turned on for the video, then the page remains open for the Duration of 6 seconds. @swissspidy -- is it valid to have the page adv auto duration ignored if there is a video playing in the page that is longer duration ? |
|
Yes this is expected behavior. |
Thanks for thinking about this and for the suggestion! I believe @aaskedall recommended using something like "Default Page Advancement" in the Document settings, we're currently still waiting for the mocks though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This adds a new custom per-page page advancement panel.
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Checklist
Type: XYZlabel to the PRFixes #12210