-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media: Clean up linked post meta on attachment deletion #12321
Conversation
Plugin builds for 9e34261 are ready 🛎️!
|
Size Change: 0 B Total Size: 2.72 MB ℹ️ View Unchanged
|
web_stories_muted_id
not cleaned up on attachment deletion
Can we do The only difference is that this works on all post types, not just attachments. But since these are prefixed meta keys that ar only used by us and only for attachments, that's OK. This will greatly simplify the code and we don't have to establish a |
7bd9853
to
3d81066
Compare
I always for forget about that with the metadata api. That is way simpler. I have pushed a change to be do this. |
Error Reproduction: I recreated the issue in Bug Fix: I switched over to
|
Permutations: In order to test around other media clean up events, I added background audio and then deleted the original file, to confirm there are no side effects. |
Context
If you delete a muted / optimized version of a video, also delete the post meta to link to the original video.
Summary
Relevant Technical Choices
I created a util class so that the code can be shared. I thought about an abstract and traits to share code. A util class is what I needed up with.
I would like to avoid doing a meta query, but I can't think of a way around it, other than a raw database query.
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZ
label to the PRFixes #12240