Checklist: Fix AMP validation false positive #12348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 6063ab9 are ready 🛎️!
|
|
Size Change: -6 B (0%) Total Size: 2.73 MB ℹ️ View Unchanged
|
swissspidy
requested review from
miina,
spacedmonkey,
timarney and
barklund
miina
approved these changes
Sep 21, 2022
timarney
approved these changes
Sep 22, 2022
spacedmonkey
approved these changes
Sep 22, 2022
|
Recreated the error in Verified the fix in #12348 branch Confirmed that indeed there were no AMP errors in this story |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The AMP validation check was incorrectly showing up in some cases
Summary
This should fix the false positive we're seeing.
The support team has already confirmed that this fix works.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #12347