-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background Audio: fix types and link conflict #12407
Conversation
Size Change: +17 B (0%) Total Size: 2.71 MB ℹ️ View Unchanged
|
Plugin builds for af799aa are ready 🛎️!
|
ReCreated this issue on
Verified the fix using test web-story
Permutations:
|
This is expected behavior.
This is expected behavior. |
Context
Non-looping background audio clashed with link elements on a page.
Also, because of a type bug, the
length
was not passed when saving background audio, causing the "Loop" control to not be displayed.Summary
<amp-video>
element was overlaying any links, making links not clickable.Relevant Technical Choices
Extended e2e test to cover the "Loop" control
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #12384