Increase admin submenu z-index #12443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Bug
swissspidy
force-pushed
the
fix/12433-z-index
branch
from
f770075
to
3142d83
Compare
|
Plugin builds for 907a08a are ready 🛎️!
|
|
Size Change: +89 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
|
This change made my editor hang |
|
Yeah mine too, which is why this is still WIP. Now I know it‘s not just me though! Might be because I forgot to close that comment. Will look into it again. |
|
Saw it was a WIP, but didn't know it was crashing your browser. Thought I would flag issue and test as I am assigned. |
swissspidy
force-pushed
the
fix/12433-z-index
branch
from
3142d83
to
907a08a
Compare
swissspidy
changed the title
|
Alright, now the bug should be fixed and things working as expected. PTAL. |
|
It does seem like fixes the issue. But I noticed the admin bar doesn't work now. Screen.Recording.2022-10-11.at.17.48.31.mov |
|
Ugh, WordPress 🙃 |
This is not a bug introduced by this PR. This is also broken on main. I will look into it. |
|
Couldn't find a quick solution, opened #12479 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When a dialog (e.g. the “story is locked” dialog) is showing, the dialog grayout is above the main WP menu dropdowns, so you cannot actually use the WP menu while any dialog is showing.
Summary
Increases the WordPress admin submenu z-index whenever a dialog is open.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #12433