-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block: Remove minimum width from grid items #12469
Conversation
Plugin builds for 5a1b4b0 are ready 🛎️!
|
Size Change: -77 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
Does this affect anything on the frontend? Could you add QA instructions? |
@swissspidy Not adding QA instructions is by design. Want to get thoughts on the PR first. In my limited testing, I can't see any effect. QA might be better than me to look. As I don't write the block, it is hard to know why this min width value was required in the first place. I am also not sure if this what the workaround / fix we would want. It may result in different styling than desired. |
I'll check it out, but instructions are helpful for code reviewers too. |
Not sure what instructions I can give. The video shows the new behaviour. It is more about setting it to 4 columns and testing the responsive. |
Context
Summary
Remove min width of story and let flex box do it's own things.
Relevant Technical Choices
Removing min width might mean stories look diffferent or other styling issues.
To-do
User-facing changes
Screen.Recording.2022-10-13.at.18.03.53.mov
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #11960