TypeScript: Convert elements package
#12508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Infrastructure
|
Plugin builds for 3170927 are ready 🛎️!
|
|
Size Change: +236 B (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
spacedmonkey
suggested changes
Oct 19, 2022
|
There is a lint error again. |
|
It's an issue with ESLint on |
miina
approved these changes
Oct 19, 2022
swissspidy
commented
Oct 24, 2022
Comment on lines
+23
to
+32
| interface BaseDefinition { | ||
| type: string; | ||
| name: string; | ||
| defaultAttributes: Record<string, unknown>; | ||
| } | ||
|
|
||
| export interface PageElementDefinition extends BaseDefinition { | ||
| type: 'page'; | ||
| defaultAttributes: Record<string, never>; | ||
| } |
There was a problem hiding this comment.
This part is not really ideal because of our special 'page' element type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This helps unblock some other conversion work, like for the
outputand themaskspackages.Summary
Convert the
elementspackage to TS.Relevant Technical Choices
unitspackagetypespackageTo-do
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRSee #12126