Slug: allow unicode characters #12603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 257cb2d are ready 🛎️!
|
|
Size Change: +1.82 kB (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
|
While we're at it: In WordPress, when you publish a post with the title
Whereas we show the encoded slug:
Can we align this as well? Otherwise looks good |
spacedmonkey
reviewed
Nov 2, 2022
spacedmonkey
reviewed
Nov 2, 2022
Comment on lines
65
to
68
| it('should allow using unicode characters', () => { | ||
| const result = cleanForSlug('హల-వరలడ'); | ||
| expect(result).toBe('హల-వరలడ'); | ||
| }); |
There was a problem hiding this comment.
Lets add a data set of different slugs and expected return. Maybe test Cyrillic script, Arabic, Other unicode characters, accented characters like È, hindi characters and mandarin chinese.
There was a problem hiding this comment.
Added a few more in 7565ca8. Accented characters are already handled in a previous test (see the first test of the file).
swissspidy
reviewed
Nov 2, 2022
swissspidy
reviewed
Nov 2, 2022
swissspidy
approved these changes
Nov 2, 2022
|
Note: the encoded slug shows up properly in the address bar within Chrome and within the story editor link display Verified with Kanji characters as well https://stories-qa-wordpress-amp.pantheonsite.io/web-stories/kanji-%e6%bc%a2%e5%ad%97-2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Allows unicode characters in the slug. Also, adds using
remove-accentspackage.Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12546