Remove scaling properties from non-media elements #12605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
added
Type: Code Quality
miina
commented
Nov 1, 2022
| @@ -86,6 +86,10 @@ export interface ElementV0 extends ElementBoxV0 { | |||
| groupId?: string; | |||
| border?: BorderV0; | |||
| borderRadius?: BorderRadiusV0; | |||
|
|
|||
| scale?: number; | |||
There was a problem hiding this comment.
Apparently all the elements had those added.
|
@swissspidy I haven't been able to repro images having |
|
This was purely from typing the templates, so probably just leftovers there. |
|
Plugin builds for 25cfe48 are ready 🛎️!
|
|
Size Change: +53 B (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
|
Confirmed that the I created a test story with all types of elements embedded - please see the test story here: Verify fix of #12605
Confirmed that
Confirmed that with ISSUE: WITH FIX: Also verified that scaling and moving the media elements DOES continues to work, and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Remove
scale,focalX,focalYfrom elements that are not media. Apparently all the elements were added those properties.Relevant Technical Choices
To-do
backgroundColorending up in media properties (haven't been able to repro yet)User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
shift + option + cmd + J)Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12437