Run unit tests against WordPress 5.9+ #12608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Type: Infrastructure
swissspidy
reviewed
Nov 2, 2022
.github/workflows/tests-unit-php.yml
Outdated
Comment on lines
125
to
139
| # Installs a different PHPUnit version depending on the WP/PHP version combo we're testing against. | ||
| # | ||
| # | WP / PHP | PHPUnit | | ||
| # |-----------|---------| | ||
| # | 5.7 / 7.4 | 7 | | ||
| # | 5.9 / 7.4 | 8 | | ||
| # | 5.9 / 7.4 | 9 | | ||
| # | * / 8 | 9 | | ||
| # | ||
| # See https://make.wordpress.org/core/handbook/references/phpunit-compatibility-and-wordpress-versions/ | ||
| - name: Update PHPUnit | ||
| run: | | ||
| if [[ $WP_VERSION == "5.7" && $PHP_VERSION == "7.4" ]]; then | ||
| echo "Installing PHPUnit 7.5.x" | ||
| composer require --no-interaction --no-scripts phpunit/phpunit:^7.5 --with-dependencies | ||
| elif [[ $WP_VERSION == "latest" || $WP_VERSION == "trunk" || $PHP_VERSION == "7.4" ]]; then | ||
| echo "Installing latest version of PHPUnit" | ||
| composer update --ignore-platform-reqs --no-interaction --no-scripts yoast/phpunit-polyfills --with-dependencies | ||
| fi | ||
| env: | ||
| WP_VERSION: ${{ matrix.wp }} | ||
| PHP_VERSION: ${{ matrix.php }} | ||
|
|
There was a problem hiding this comment.
Right now, with removing this, all tests are running with PHPUnit 8.5 as can be seen here:
We still need the composer update --ignore-platform-reqs --no-interaction --no-scripts yoast/phpunit-polyfills --with-dependencies line to update to PHPUnit 9.5.
Once we actually bump the minimum PHP version requirement in #12583, we can remove this and update the dependency permanently in composer.json via composer update
swissspidy
reviewed
Nov 3, 2022
Co-authored-by: Pascal Birchler <pascalb@google.com>
spacedmonkey
commented
Nov 3, 2022
swissspidy
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12573