Block: Use getUsers with capability query
#12615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Type: Enhancement
|
Plugin builds for ff81376 are ready 🛎️!
|
|
Size Change: +45 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
|
So IIUC this replaces the deprecated But in WP 5.9 Because then we can get rid of the workaround in So something like const { authors } = useSelect(
(select) => {
const { getUsers, getPostType } = select(coreStore);
const capabilities = getPostType('web-story')?.capabilities['edit_posts'];
const query = {
search: authorKeyword,
capabilities,
};
return {
authors: getUsers(query),
};
},
[authorKeyword]
);Uses optional chaining for the Because of that, probably actually better to do this: const { authors } = useSelect(
(select) => {
const { getUsers, getPostType } = select(coreStore);
const capabilities = getPostType('web-story')?.capabilities['edit_posts'];
const query = {
search: authorKeyword,
capabilities,
};
return {
// Only load users when capability has been fetched already.
authors: capabilities ? getUsers(query) : [],
};
},
[authorKeyword]
); |
|
@swissspidy Your fix seems to work. Should I remove this |
|
Yes |
Done |
swissspidy
changed the title
getUsers with capability query
swissspidy
added
the
Type: Code Quality
swissspidy
approved these changes
Nov 9, 2022
|
ReCreated this issue on stories-QA using Confirmed the fix via QA Note: When the author drop down is pressed, the cover image seems to hide the authors list @swissspidy @spacedmonkey - is it within scope of this ticket to ensure that the select-story :: drop down of the authors list should be visible ? |
|
No, not at all. Styling fixes are in progress at #12649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Replace
getAuthorswithgetUsers.Followed this example - WordPress/gutenberg#33695
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #9240