-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript: story-editor
config provider
#12619
Conversation
import Context from './context'; | ||
|
||
function useConfig(selector) { | ||
function useConfig(): ConfigState; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useConfig()
is actually only used like this line here, it seems (without using props).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, because the state never changes anyway.
Plugin builds for 2e22e74 are ready 🛎️!
|
Size Change: +2.03 kB (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG and a note here too: Don't worry about the failing Karma tests, I'm fixing them here.
Context
Summary
Converts the
config
folder ofstory-editor
package to TypeScript.Relevant Technical Choices
Currently only loads the
config
folder and thetypes
folder in the config.To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #12581