Data Structure: reduce redundancy when storing fonts #12625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
timarney
added
Group: Fonts
Pod: WP
Package: Story Editor
timarney
changed the title
|
Plugin builds for 373f526 are ready 🛎️!
|
|
Size Change: +300 B (0%) Total Size: 2.71 MB
ℹ️ View Unchanged
|
miina
reviewed
Nov 23, 2022
swissspidy
changed the title
merapi
approved these changes
Nov 28, 2022
|
For testing you should be able to look at the network request when saving For example: I added 8 text elements to a page You should see a fonts property on the story data Each individual text element should only contain font family:
|
|
Confirmed that with the
After the change: Before the change ( Screenshot of adding same text but with different size on the same page Note that the font info remains the same (a reference to the fonts property), but the size is specific to the element. |
|
Confirmed that google fonts as well as custom fonts added to the web story plugin both work as expected. |
@merapi good to merge? |
LG to me, I tested in on Windows and was also OK. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a follow-up to #12131.
Right now when adding 10 text elements all with the same font, there will be 10 font objects being stored, all with the same information. That's very redundant.
Instead of this, consider storing all existing fonts at the story level instead of on each element to reduce redundancy.
Summary
Keeps as much of the existing code i.e. calls to calcFontMetrics(element) the same while reducing how we store the font data.
When Saving or Updating
getStoryPropsToSave.js👉 At this point we should have clean / reduced font storage
When we re-load
useLoadStory.js👉 At this point we should have clean font data at the story level and the data back on the elements --- meaning code that wants to get the data from the element (font) can do so vs #12445 where I introduced a new elementFontData param for passing font data.
See before and after:
#12625 (comment)
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
This PR makes updates to font strorage we shouldn't see any visual changes while editing, previewing or outputting a story.
#12625 (comment)
If you have access to the database you can check the way stories are saved i.e.
#12625 (comment)
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12261