TypeScript: convert HistoryProvider
#12674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
added
Type: Code Quality
miina
commented
Nov 10, 2022
|
Plugin builds for 12693f6 are ready 🛎️!
|
|
Size Change: +271 B (0%) Total Size: 2.72 MB
ℹ️ View Unchanged
|
miina
commented
Nov 13, 2022
miina
commented
Nov 13, 2022
barklund
reviewed
Nov 18, 2022
| @@ -31,7 +31,10 @@ import type { DependencyList } from 'react'; | |||
| * @param [deps] The optional callback dependencies. | |||
| * @return The memoized batching function. | |||
| */ | |||
| function useBatchingCallback<T extends (...args: unknown[]) => unknown>( | |||
| function useBatchingCallback< | |||
| T extends (...args: [event: KeyboardEvent]) => void | |||
There was a problem hiding this comment.
Shouldn't it just always return type T? Wouldn't that work?
function useBatchingCallback<T extends (...args: unknown[]) => void>(
callback: T,
deps: DependencyList
): T {
|
This pull request introduces 1 alert when merging 9f9f11f into 00df91d - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Comment on lines
+75
to
+76
| ? () => () => undefined | ||
| : usePreventWindowUnload; |
There was a problem hiding this comment.
Are you asking why is the change {} to undefined needed?
Since {} is not allowed by the linting rules then using undefined instead. Originally I ignored the eslint error but Morten had the idea of using undefined instead. It doesn't really change anything.
barklund
approved these changes
Nov 23, 2022
| @@ -31,7 +31,10 @@ import type { DependencyList } from 'react'; | |||
| * @param [deps] The optional callback dependencies. | |||
| * @return The memoized batching function. | |||
| */ | |||
| function useBatchingCallback<T extends (...args: unknown[]) => unknown>( | |||
| function useBatchingCallback< | |||
| T extends (...args: [event: KeyboardEvent]) => void | |||
There was a problem hiding this comment.
Hm, not sure why that doesn't work, but this does. I don't know if we ever need callbacks with more than one argument, but if we do, this supports up to three args (and it's butt-ugly):
function useBatchingCallback<T>(
callback: (arg: T) => void,
deps: DependencyList
): (arg: T) => void;
function useBatchingCallback<T, U>(
callback: (arg1: T, arg2: U) => void,
deps: DependencyList
): (arg1: T, arg2: U) => void;
function useBatchingCallback<T, U, V>(
callback: (arg1: T, arg2: U, arg3: V) => void,
deps: DependencyList
): (arg1: T, arg2: U, arg3: V) => void;
function useBatchingCallback<T extends (...args: unknown[]) => void>(
callback: T,
deps: DependencyList
) {
return useCallback(
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument -- Just passing through
(...args) => batchedUpdates(() => callback(...args)),
// eslint-disable-next-line react-hooks/exhaustive-deps -- Pass through provided deps.
deps
);
}
swissspidy
reviewed
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Converts
historyProviderinto TypeScriptSummary
Relevant Technical Choices
Ignoresdesign-systemimport for now. Is there a better option?To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12666