TypeScript: Convert output package
#13504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
changed the title
output package
swissspidy
added
Type: Infrastructure
|
Size Change: +223 B (0%) Total Size: 2.77 MB
ℹ️ View Unchanged
|
|
Plugin builds for 53c46c3 are ready 🛎️!
|
|
@AnuragVasanwala @Swanand01 This here is a huge change to add more type safety to yet another package in the code base. While I'm mostly confident in the change, it would be really great if you could skim over it as well to see if anything stands out to you as incorrect or missing. |
swissspidy
commented
Mar 25, 2024
Comment on lines
+22
to
+26
| export interface AudioResource | ||
| extends Pick< | ||
| Resource, | ||
| 'type' | 'id' | 'src' | 'mimeType' | 'isExternal' | 'isPlaceholder' | ||
| > { |
There was a problem hiding this comment.
This type is not 100% accurate because AudioResource doesn't actually use any of these fields in the editor. It doesn't really extend Resource. Something to fix in the future.
swissspidy
commented
Mar 25, 2024
AnuragVasanwala
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
@swissspidy I and @Swanand01 have gone through the PR. It is a quite extensive and as we have limited context, we were not able to verify everything.
Although, we didn't find anything odd or missing.
Looks good to us ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12089