Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests against PHP 8.4 alpha #13607

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Run unit tests against PHP 8.4 alpha #13607

merged 1 commit into from
Apr 29, 2024

Conversation

swissspidy
Copy link
Collaborator

@swissspidy swissspidy commented Mar 25, 2024

Summary

Run tests against PHP 8.4 to see if our plugin still works as expected.

So far it looks good; all the deprecation warnings are coming from elsewhere.

Blocked by:

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #

@swissspidy swissspidy added the Type: Infrastructure Changes impacting testing infrastructure or build tooling label Mar 25, 2024
@swissspidy swissspidy marked this pull request as draft March 25, 2024 12:47
@swissspidy swissspidy marked this pull request as ready for review April 15, 2024 20:58
@swissspidy swissspidy merged commit 1ee32ce into main Apr 29, 2024
17 checks passed
@swissspidy swissspidy deleted the try/php84 branch April 29, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant