Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Tests: Suppress 404s in Embed Block test #6820

Merged
merged 1 commit into from
Mar 19, 2021
Merged

E2E Tests: Suppress 404s in Embed Block test #6820

merged 1 commit into from
Mar 19, 2021

Conversation

spacedmonkey
Copy link
Contributor

@spacedmonkey spacedmonkey commented Mar 18, 2021 •
edited
Loading

Context

Summary

Suppress error to make e2e test pass.

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

  • UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #6237

@google-cla google-cla bot added the cla: yes label Mar 18, 2021
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 1.65 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/carousel-view-rtl.css 715 B 0 B
assets/css/carousel-view.css 716 B 0 B
assets/css/edit-story-rtl.css 267 B 0 B
assets/css/edit-story.css 267 B 0 B
assets/css/stories-dashboard-rtl.css 284 B 0 B
assets/css/stories-dashboard.css 284 B 0 B
assets/css/vendors~edit-story-rtl.css 702 B 0 B
assets/css/vendors~edit-story.css 702 B 0 B
assets/css/web-stories-block-rtl.css 3.23 kB 0 B
assets/css/web-stories-block.css 3.26 kB 0 B
assets/css/web-stories-embed-rtl.css 284 B 0 B
assets/css/web-stories-embed.css 284 B 0 B
assets/css/web-stories-list-styles-rtl.css 2.26 kB 0 B
assets/css/web-stories-list-styles.css 2.27 kB 0 B
assets/css/web-stories-theme-style-twentyeleven-rtl.css 102 B 0 B
assets/css/web-stories-theme-style-twentyeleven.css 102 B 0 B
assets/css/web-stories-theme-style-twentyfifteen-rtl.css 252 B 0 B
assets/css/web-stories-theme-style-twentyfifteen.css 252 B 0 B
assets/css/web-stories-theme-style-twentyfourteen-rtl.css 286 B 0 B
assets/css/web-stories-theme-style-twentyfourteen.css 286 B 0 B
assets/css/web-stories-theme-style-twentyseventeen-rtl.css 311 B 0 B
assets/css/web-stories-theme-style-twentyseventeen.css 311 B 0 B
assets/css/web-stories-theme-style-twentysixteen-rtl.css 239 B 0 B
assets/css/web-stories-theme-style-twentysixteen.css 239 B 0 B
assets/css/web-stories-theme-style-twentyten-rtl.css 144 B 0 B
assets/css/web-stories-theme-style-twentyten.css 145 B 0 B
assets/css/web-stories-theme-style-twentytwelve-rtl.css 263 B 0 B
assets/css/web-stories-theme-style-twentytwelve.css 263 B 0 B
assets/css/web-stories-theme-style-twentytwenty-rtl.css 86 B 0 B
assets/css/web-stories-theme-style-twentytwenty.css 86 B 0 B
assets/css/web-stories-theme-style-twentytwentyone-rtl.css 263 B 0 B
assets/css/web-stories-theme-style-twentytwentyone.css 265 B 0 B
assets/css/web-stories-widget.css 489 B 0 B
assets/js/carousel-view.js 3.72 kB 0 B
assets/js/chunk-fonts-********************.js 45 kB 0 B
assets/js/chunk-web-stories-template-0-********************.js 11 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 11.3 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 10.9 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.6 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 12.7 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 7.14 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 10.3 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 10.1 kB 0 B
assets/js/chunk-web-stories-textset-0-********************.js 5.23 kB 0 B
assets/js/chunk-web-stories-textset-1-********************.js 6.79 kB 0 B
assets/js/chunk-web-stories-textset-2-********************.js 7.81 kB 0 B
assets/js/chunk-web-stories-textset-3-********************.js 15.3 kB 0 B
assets/js/chunk-web-stories-textset-4-********************.js 4.38 kB 0 B
assets/js/chunk-web-stories-textset-5-********************.js 5.64 kB 0 B
assets/js/chunk-web-stories-textset-6-********************.js 5.43 kB 0 B
assets/js/chunk-web-stories-textset-7-********************.js 10.3 kB 0 B
assets/js/edit-story.js 339 kB 0 B
assets/js/lightbox.js 986 B 0 B
assets/js/stories-dashboard.js 264 kB 0 B
assets/js/tinymce-button.js 3.48 kB 0 B
assets/js/vendors~chunk-ffmpeg-********************.js 5.61 kB 0 B
assets/js/vendors~edit-story-********************.js 61.4 kB 0 B
assets/js/vendors~edit-story~stories-dashboard-********************.js 267 kB 0 B
assets/js/web-stories-activation-notice.js 68.2 kB 0 B
assets/js/web-stories-block.js 424 kB 0 B
assets/js/web-stories-embed.js 492 B 0 B
assets/js/web-stories-widget.js 984 B 0 B

compressed-size-action

@swissspidy swissspidy changed the title E2E Tests: Improve flakey Embed Block test E2E Tests: Suppress 404s in Embed Block test Mar 18, 2021
@swissspidy swissspidy added Pod: WP & Infra Type: Infrastructure Changes impacting testing infrastructure or build tooling labels Mar 18, 2021
Base automatically changed from main to _main March 18, 2021 18:48
@swissspidy swissspidy closed this Mar 18, 2021
@swissspidy swissspidy deleted the branch main March 18, 2021 18:51
@swissspidy swissspidy reopened this Mar 18, 2021
@swissspidy swissspidy changed the base branch from _main to main March 18, 2021 19:01
swissspidy
swissspidy approved these changes Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know whether this 404 is legit or not.

But I suppose this is OK for now

@swissspidy swissspidy merged commit 274e529 into main Mar 19, 2021
@swissspidy swissspidy deleted the fix/amp-flakey-1 branch March 19, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E Tests: Improve flakey Embed Block test
2 participants
@spacedmonkey @swissspidy