Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(modal): correction ombre modal footer [DS-3061] #572

Merged
merged 5 commits into from
May 17, 2023
Merged

🐛 fix(modal): correction ombre modal footer [DS-3061] #572

merged 5 commits into from
May 17, 2023

Conversation

keryanS
Copy link
Contributor

@keryanS keryanS commented Mar 27, 2023 •
edited
Loading

L'ombre du footer de la modal scrollable est mal placée et trop forte.

  • Remplacement de l'ombre par une bordure d'1px en defaut-grey en haut du footer
  • remplacement du token de background-color du footer par background-lifted-grey
  • ajout d'un texte plus long dans l'exemple modal + footer pour faire apparaitre le scroll

@keryanS keryanS added the correctif Quelque chose ne fonctionne pas label Mar 27, 2023
@keryanS keryanS added this to the 1.10.0 milestone Mar 27, 2023
@keryanS keryanS requested a review from lab9fr March 27, 2023 14:03
@keryanS keryanS self-assigned this Mar 27, 2023
@lab9fr lab9fr changed the title fix(modal): correction ombre modal footer [DS-3061] 🐛 fix(modal): correction ombre modal footer [DS-3061] Mar 27, 2023
@lab9fr lab9fr changed the base branch from main to dev-1.9.3 May 12, 2023 14:02
@lab9fr lab9fr modified the milestones: 1.10.0, 1.9.3 May 12, 2023
@lab9fr lab9fr added the Prêt label May 16, 2023
@lab9fr lab9fr merged commit 01d2e07 into dev-1.9.3 May 17, 2023
@lab9fr lab9fr deleted the fix/modal-footer branch May 17, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lab9fr lab9fr lab9fr approved these changes

Assignees

@keryanS keryanS

Labels
correctif Quelque chose ne fonctionne pas Prêt
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@keryanS @lab9fr