🐛 fix(core): corrige liens pour retro-compat sur firefox [DS-3288] #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zellerbaptiste
commented
Jun 13, 2023
•
zellerbaptiste
commented
- La fonction css max(), mise en place pour corriger le bug d'affichage d'un soulignement d'une épaisseur inférieure à 1px, est supportée à partir de la version 78 de firefox, ce qui est insuffisant.
- Le précédent bug est maintenant corrigé avec un léger épaississement du trait sur firefox (0.25px)
lab9fr
force-pushed
the
fix/core-firefox-support
branch
from
55fcfc8
to
6f627a9
Compare
lab9fr
changed the title
lab9fr
approved these changes
Jun 15, 2023
lab9fr
changed the title
lab9fr
changed the title
lab9fr
approved these changes
Jun 16, 2023
lab9fr
approved these changes
Jun 16, 2023
|
Malheureusement il semble que le patch sur dsfr 1.10 n'est pas suffisant. Sur le site https://main--ds-gouv.netlify.app/example/component/link/ à 50 % il manque encore des soulignement de liens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.