-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weâll occasionally send you account related emails.
Already on GitHub? Sign in to your account
đ fix(header): ajustements header [DS-3601, DS-3368] #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
keryanS
commented
Sep 15, 2023
•
edited
Loading
edited
- change la couleur du menu burger en $action-high-bleu-france en mobile
- passe l'écart entre bloc marque et logo opérateur à 32px et l'écart entre logo opérateur et nom du site à 32px
- réduit la taille de la barre de recherche à 96v (24rem) au lieu de 25rem
- bloque la taille du logo opérateur à 8rem max (128px)
- passe la taille du texte de la tagline en sm (14px) au lieu de md
- passe le bouton burger en tertiaire avec border
âŠ735) - Les cookies obligatoires doivent ĂȘtre systĂ©matiquement cochĂ©s
- passe le max-width de la barre de recherche Ă 96v (384px)
keryanS
changed the title
fix(header): ajustements header [DS-3601]
đ fix(header): ajustements header [DS-3601]
Sep 15, 2023
zellerbaptiste
approved these changes
Sep 18, 2023
lab9fr
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ă merger avec la #722 (ou plutĂŽt l'inverse) ces 2 PR traitant du mĂȘme sujet, mais pouvant entrer en conflit. Une seule PR contenant tous les changements de ces 2 tickets sera plus sĂ»r et efficace.
- feat(header): corrige la couleur et les espacements des icones menu et burger en mobile
keryanS
changed the title
đ fix(header): ajustements header [DS-3601]
đ fix(header): ajustements header [DS-3601, DS-3368]
Oct 20, 2023
lab9fr
approved these changes
Nov 10, 2023
This was referenced Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.