✨ feat(analytics): ajout de la version du site [DS-3718] #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lab9fr
commented
Jan 19, 2024
lab9fr
commented
- ajouts de la propriété de version du site dans les données de mesure d'audience
| @@ -18,6 +18,7 @@ window.dsfr.analytics.site | |||
| type: 'type', // site type | |||
| region: 'FR-IDF', // region of the website (ISO 3166-2:FR) | |||
| department: 'FR-75', // department of the website (ISO 3166-2:FR) | |||
| version: '1.0.0', // version of the website | |||
There was a problem hiding this comment.
est-ce qu'on devrait préciser site_version comme entrée pour se différencier de la version du DSFR ou d'une librairie tierce ?
There was a problem hiding this comment.
C'est ce que l'on a en sortie
department donne site_department
donc je suis parti du principe que l'on a version pour site_version
on a aussi en sorti api_version pour la version du dsfr
There was a problem hiding this comment.
Je ne comprends pas trop la valeur site_department car un site n'est pas géolocalisé il me semble ?
Pour plus de clarté j'aurai préféré site_version en entrée ET sortie mais si tu veux rester consistant avec les autres clés pas de soucis.
zellerbaptiste
approved these changes
Jan 19, 2024
keryanS
approved these changes
Jan 19, 2024
keryanS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.