fixes infinite loop in stepWidth computation of the range Component #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merci pour la proposition de correction, j'ai créé une PR plus globale qui corrige d'autres problèmes sur le curseur : #931 Je ferme donc cette PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Après avoir incorporé le composant Range dans une page utilisant le dsfr,
le chargement de la page est bloqué. Même expérience sous Safari, Chrome et Firefox. Firefox propose de fermer la page qui consomme trop de ressources. La suppression du composant range corrige le problème.
Sous certaine conditions, une boucle infinie de calcul peut apparaître dans le calcul de la largeur d'un pas dans src/component/range/script/range/range-model.js
Dans la ligne
dsfr/src/component/range/script/range/range-model.js
Line 143 in 0872677
la boucle ne s'arrête pas si _stepWidth vaut -Infinite. Cela peut arriver si la division précédente a un quotient 0.
Le patch proposé dans cette PR semble corriger le problème.