Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated Nonce type Instead of u32 in account diff #1287

Closed
trevorbernard opened this issue Jul 11, 2024 · 0 comments · Fixed by #1294
Closed

Use dedicated Nonce type Instead of u32 in account diff #1287

trevorbernard opened this issue Jul 11, 2024 · 0 comments · Fixed by #1294
Assignees
@jhult
Labels
Enhancement Enhancement to an existing feature Good First Issue Good issue for newcomers to tackle

Comments

@trevorbernard
Copy link
Collaborator

Currently, Nonce is represented as a u32 in the account diff. To improve type safety and code clarity, we should introduce a dedicated Nonce type.
@trevorbernard trevorbernard added Enhancement Enhancement to an existing feature Good First Issue Good issue for newcomers to tackle labels Jul 11, 2024
@jhult jhult self-assigned this Jul 11, 2024
jhult added a commit to jhult/mina-indexer that referenced this issue Jul 15, 2024
@jhult
feat: use dedicated Nonce type Instead of u32
b0dfd34 
Fixes Granola-Team#1287
@jhult jhult mentioned this issue Jul 15, 2024
Merged
jhult added a commit to jhult/mina-indexer that referenced this issue Jul 15, 2024
@jhult
feat: use dedicated Nonce type (instead of u32)
af48957 
Fixes Granola-Team#1287
@jhult jhult removed their assignment Jul 15, 2024
trevorbernard pushed a commit that referenced this issue Jul 15, 2024
@jhult
feat: use dedicated Nonce type (instead of u32) (#1294)
baecaf3 
Fixes #1287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhult jhult

Labels
Enhancement Enhancement to an existing feature Good First Issue Good issue for newcomers to tackle
Projects
MinaSearch.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use dedicated Nonce type Instead of u32 jhult/mina-indexer
2 participants
@trevorbernard @jhult