Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto: factorize logs folders retrieval #398

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jan 22, 2024

No description provided.

@Guts Guts requested a review from jmkerloch January 22, 2024 11:21
@github-actions github-actions bot added the quality Tests, project resiliency, etc. label Jan 22, 2024
@Guts Guts self-assigned this Jan 22, 2024
Copy link
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark for logs.

qgis_deployment_toolbelt/constants.py Outdated Show resolved Hide resolved
@Guts Guts requested a review from jmkerloch January 22, 2024 13:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fb49e8) 71.28% compared to head (d4f18ba) 71.45%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   71.28%   71.45%   +0.16%     
==========================================
  Files          43       43              
  Lines        2448     2452       +4     
  Branches      521      522       +1     
==========================================
+ Hits         1745     1752       +7     
+ Misses        526      524       -2     
+ Partials      177      176       -1     
Files Coverage Δ
qgis_deployment_toolbelt/constants.py 82.89% <100.00%> (+2.59%) ⬆️
qgis_deployment_toolbelt/utils/journalizer.py 72.13% <100.00%> (+1.98%) ⬆️

Copy link
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion for correct folder use in logs and it's good !

qgis_deployment_toolbelt/constants.py Outdated Show resolved Hide resolved
Co-authored-by: jmkerloch <53606373+jmkerloch@users.noreply.github.com>
Signed-off-by: Julien <dev@ingeoveritas.com>
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts requested a review from jmkerloch January 23, 2024 10:04
@Guts Guts merged commit 30c5afd into main Jan 23, 2024
25 checks passed
@Guts Guts deleted the refacto/factorize-logs-folders-retrieval branch January 23, 2024 10:07
@Guts
Copy link
Owner Author

Guts commented Jan 23, 2024

Thanks @jmkerloch for your attentive review, really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants