Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

Different performances between different python versions #2

Open
alphadl opened this issue Dec 9, 2018 · 14 comments
Open

Different performances between different python versions #2

alphadl opened this issue Dec 9, 2018 · 14 comments

Comments

@alphadl
Copy link

alphadl commented Dec 9, 2018

My setting and data is totally implemented from your repository, I see from your paper that the results of "Path Finding" is 99.99 %, however, after running 100 epochs(which is your default epoch number), the best acc on Dev is only 0.145, and the best acc on Test is only 0.119 which is extremely different from what you have got .

I want to reproduce your results as the paper said. Is there any tricks I missed or something else?

Thanks for your patience~

@syxu828
Copy link

syxu828 commented Dec 9, 2018

Hi, which data you are using ? can you show me the data that you used in training the model ?

@alphadl
Copy link
Author

alphadl commented Dec 9, 2018

I used the data just in this repository :https://github.com/IBM/Graph2Seq/tree/master/data/no_cycle

@alphadl
Copy link
Author

alphadl commented Dec 9, 2018

thanks for your timely reply, I just emailed you, hope my brusque email does not disturb your weekend :)

@syxu828
Copy link

syxu828 commented Dec 9, 2018 via email

@alphadl
Copy link
Author

alphadl commented Dec 9, 2018

I tried your trained model in /saved_model initially by using the command : python run_model test, but I got a low score, maybe about 0.1

@syxu828
Copy link

syxu828 commented Dec 9, 2018

let me double check it

@syxu828
Copy link

syxu828 commented Dec 9, 2018

Hi, I have the similar results using the CPU based tensorlfow. But I can reproduce the results on the GPU-tensorflow. My TensorFlow version is 1.8.0. I have not figured it out. But I suggest you to use the GPU-tensorflow. And you should specify some params (-sample_size_per_layer=100 -hidden_layer_dim=50 -epochs=200) in both the training and testing to achieve the reported results.

@alphadl
Copy link
Author

alphadl commented Dec 10, 2018

Kun, many thanks to you again~ I tried it on GPU based tensorflow and got the same level result as CPU based, here is my running log: https://colab.research.google.com/drive/16JmGN7coPxOa1W9inpvgzXc0uucwDYGa

@syxu828
Copy link

syxu828 commented Dec 10, 2018 via email

@alphadl
Copy link
Author

alphadl commented Dec 10, 2018

quite a strange phenomenon~ I just used python3.5 in my laptop without GPU and finally get nearly acc 0.8 in Dev after 290 epochs

@syxu828
Copy link

syxu828 commented Dec 10, 2018

Your performance is much lower than what it is expected :-( . On my computer, it achieves the reported performance...

@alphadl
Copy link
Author

alphadl commented Dec 13, 2018

maybe because I used the CPU version TensorFlow ~ anyway, thank you 👍 . If you find out why there are so many differences in performance between different python versions, you could leave a message here : )

@alphadl alphadl changed the title can not reproduce the result in your paper Different performances between different python versions Dec 13, 2018
@syxu828
Copy link

syxu828 commented Dec 13, 2018

Thanks for pointing out this. I will investigate this problem.

@teddylfwu
Copy link

Dear All,

Please see our newly released graph4nlp library: https://github.com/graph4ai/graph4nlp, which have implemented many GNN methods like Graph2Seq and Graph2Tree models.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants