feat: pull worker-watcher into main lunchpail binary #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starpit
force-pushed
the
worker-watcher-internal
branch
2 times, most recently
from
a8e684b
to
825aa0c
Compare
- new `lunchpail worker <run|prestop>` commands - eliminate the separate image (was: images/components/lunchpail-worker-watcher) - adds top-level Dockerfile to build lunchpail binary into an image named `lunchpail` - for build efficiency, updates hack/setup/cli.sh to use a specified GOMODCACHE (`.cache`) directory so that we can copy the cached dependencies into the container builder, thus avoiding re-fetching the cached dependencies on each dev build - updates `lunchpail images build` to build the new `lunchpail` image TODOs: - find a way to have the worker launch the application using embedded application dependencies -- i.e. in "compiled" mode; all this change does is bring the existing worker-watcher logic into the main lunchpail binary Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
starpit
force-pushed
the
worker-watcher-internal
branch
from
825aa0c
to
9bd7b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lunchpail worker <run|prestop>commandslunchpail.cache) directory so that we can copy the cached dependencies into the container builder, thus avoiding re-fetching the cached dependencies on each dev buildlunchpail images buildto build the newlunchpailimageTODOs: