Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enqueue --wait returns task exit code #148

Merged
merged 1 commit into from
Aug 15, 2024
Merged

feat: enqueue --wait returns task exit code #148

merged 1 commit into from
Aug 15, 2024

Conversation

aavarghese
Copy link
Member

@aavarghese aavarghese commented Aug 14, 2024 •
edited by starpit
Loading

Covered by test7f-wait

Fixes #145

starpit
starpit requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@starpit starpit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to os.Exit() based on the content of the code file? That is at least what #145 states.

@aavarghese aavarghese force-pushed the enqueue branch 2 times, most recently from 7f09d41 to bbc6788 Compare August 14, 2024 18:47
@aavarghese
Copy link
Member Author 

Done with /queue/processing/task.2.txt
ls: test/test7/test7: No such file or directory
Processing 0 /queue/processing/task.6.txt
Done with /queue/processing/task.6.txt
ls: test/test7/test7: No such file or directory

Looking into this err above..

@aavarghese aavarghese marked this pull request as draft August 14, 2024 20:19
@aavarghese aavarghese force-pushed the enqueue branch 2 times, most recently from 33367aa to e0b3b2d Compare August 14, 2024 20:43
@aavarghese aavarghese marked this pull request as ready for review August 14, 2024 20:59
@aavarghese aavarghese force-pushed the enqueue branch 3 times, most recently from 111bd19 to 167bde4 Compare August 14, 2024 21:50
starpit
starpit previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@starpit starpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aavarghese aavarghese force-pushed the enqueue branch 3 times, most recently from 71ea8f5 to ea2ae6d Compare August 15, 2024 13:59
@aavarghese
feat: enqueue --wait returns task exit code
41a2118 
Signed-off-by: aavarghese <avarghese@us.ibm.com>
@aavarghese
Copy link
Member Author

Will need to modify test scripts to work with multiple task failures with different RCs (Todo in a separate PR)
/cc @starpit

@aavarghese aavarghese merged commit 12d2fbe into IBM:main Aug 15, 2024
6 checks passed
@aavarghese aavarghese deleted the enqueue branch August 15, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starpit starpit starpit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: lunchpail enqueue file --wait should have exit code to match that of the task
2 participants
@aavarghese @starpit