Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Icon Button #13590

Closed
simeonoff opened this issue Oct 24, 2023 · 0 comments · Fixed by #13685
Closed

Component: Icon Button #13590

simeonoff opened this issue Oct 24, 2023 · 0 comments · Fixed by #13685

Comments

@simeonoff
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Similar to what we have in Ignite UI for Web Components, I would like to be able to have a new component/directive - igx-icon-button/igxIconButton that can support different visual styles (flat, outlined, contained), just like the igxButton. This will consequently make the need for icon type from the igxButton (igxButton='icon') obsolete.

Describe the solution you'd like

One option is to have a directive and provide the icon in a declarative way. This, in my opinion, is the better option as it makes the templating of the element easier and also keeps the API in line with the existing igxButton directive.

<button igxIconButton='outlined'>
  <igx-icon>home</igx-icon>
</button>

The other solution is to create a component that uses the Ignite UI for Web Components igc-icon-button component internally, thus inheriting styles and behaviors automatically.

Additional context

A meeting with either @rkaraivanov or @damyanpetev will be needed to discuss the options and spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants