Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon-button): implement component #13685

Merged
merged 23 commits into from
Nov 29, 2023
Merged

feat(icon-button): implement component #13685

merged 23 commits into from
Nov 29, 2023

Conversation

SisIvanova
Copy link
Collaborator

@SisIvanova SisIvanova commented Nov 14, 2023 •
edited
Loading

Closes #13590

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@SisIvanova SisIvanova marked this pull request as ready for review November 22, 2023 13:30
@SisIvanova SisIvanova added the ❌ status: awaiting-test PRs awaiting manual verification label Nov 22, 2023
simeonoff
simeonoff reviewed Nov 24, 2023
View reviewed changes
projects/igniteui-angular/src/lib/directives/button/button-base.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/directives/button/button-base.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/directives/button/button-base.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/directives/button/button.directive.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/directives/button/icon-button.directive.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/directives/button/icon-button.directive.ts Outdated Show resolved Hide resolved
...iteui-angular/src/lib/grids/filtering/excel-style/excel-style-date-expression.component.html Outdated Show resolved Hide resolved
simeonoff
simeonoff reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually things look relatively good, however, there are some minor differences around icon size (fluent theme) and border animations (material theme) when comparing against the Ignite UI for Web Components implementation.

projects/igniteui-angular/src/lib/core/styles/components/icon-button/_icon-button-theme.scss Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/core/styles/components/icon-button/_icon-button-theme.scss Outdated Show resolved Hide resolved
simeonoff
simeonoff previously approved these changes Nov 29, 2023
View reviewed changes
@simeonoff simeonoff added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 29, 2023
@simeonoff simeonoff self-requested a review November 29, 2023 13:08
simeonoff
simeonoff previously approved these changes Nov 29, 2023
View reviewed changes
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 29, 2023
@simeonoff simeonoff self-requested a review November 29, 2023 13:33
@simeonoff simeonoff merged commit d74b706 into master Nov 29, 2023
6 checks passed
@simeonoff simeonoff deleted the sivanova/icon-button-directive branch November 29, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees
No one assigned
Labels
button icon-button version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: Icon Button
2 participants
@SisIvanova @simeonoff