Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Component: Banner #2672

Closed
StefanIvanov opened this issue Oct 1, 2018 · 1 comment
Closed

New Component: Banner #2672

StefanIvanov opened this issue Oct 1, 2018 · 1 comment
Assignees
@StefanIvanov @bazal4o @wnvko
Labels
feature ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@StefanIvanov
Copy link
Contributor

Description

The Banner is a mildly interruptive interface that provides contextual information and may only be dismissed by the user (unlike Snackbar and similarly to a Dialog but in a non-modal fashion). The Banner can contain templatable content and a collection of up to two actions.
Material Banner

simple

complex
@StefanIvanov
Copy link
Contributor Author

First Draft of a Spec is available

@SlavUI SlavUI removed their assignment Oct 1, 2018
@wnvko wnvko self-assigned this Oct 3, 2018
@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Oct 3, 2018
wnvko added a commit that referenced this issue Oct 3, 2018
@wnvko
feat(igxBanner): igxBanner initial commit, #2672
cb63a72
wnvko added a commit that referenced this issue Oct 3, 2018
@wnvko
feat(igxBanner): base implementation ready with no styling, #2672
2071c80
PlamenaMiteva added a commit that referenced this issue Oct 3, 2018
@PlamenaMiteva
test(igxBanner): outline initial test scenarios #2672
8f4b441
wnvko added a commit that referenced this issue Oct 3, 2018
@wnvko
feat(igxBanner): buttons added and event listeners, #2672
d829ffd
wnvko added a commit that referenced this issue Oct 4, 2018
@wnvko
feat(igxBanner): icon add, #2672
a67d292
PlamenaMiteva added a commit that referenced this issue Oct 4, 2018
@PlamenaMiteva
test(igxBanner): fix igxExpansionPanelHeader reference to panel #2672
e17da3e
PlamenaMiteva added a commit that referenced this issue Oct 8, 2018
@PlamenaMiteva
test(igxBanner): banner initialization and events tests #2672
b9fc476
PlamenaMiteva added a commit that referenced this issue Oct 10, 2018
@PlamenaMiteva
test(igxBanner): custom template banner tests #2672
e717de0
wnvko added a commit that referenced this issue Nov 8, 2018
@wnvko
test(igxBanner): fix some failing test, #2672
4a5bee0
wnvko added a commit that referenced this issue Nov 8, 2018
@wnvko
chore(igxBanner): remove fdesribe from tests, #2672
2b6701b
wnvko added a commit that referenced this issue Nov 9, 2018
@wnvko
test(igxBanner): add some more tests, #2672
d9a6df1
@wnvko wnvko mentioned this issue Nov 9, 2018
Merged
wnvko added a commit that referenced this issue Nov 9, 2018
@wnvko
feat(igxBanner): implement IToggleView in expansion panel and in bann…
8f1a6ef 
…er, #2672
wnvko added a commit that referenced this issue Nov 9, 2018
@wnvko
docs(igxBanner): add README.md, #2672
eea3625
ViktorSlavov added a commit that referenced this issue Nov 9, 2018
@ViktorSlavov
test(igxBanner): add two more tests, #2672
89ee5d1
wnvko added a commit that referenced this issue Nov 9, 2018
@wnvko
feat(igxBanner): dev sample update, #2672
0d77b4f
ViktorSlavov pushed a commit that referenced this issue Nov 23, 2018
@wnvko @ViktorSlavov
feat(igxBanner): IgxBannerComponent implementation, #2672
e196227 
chore(igxBanner): adding missed new files

feat(igxBanner): base implementation ready with no styling, #2672

feat(igxBanner): buttons added and event listeners, #2672

test(igxBanner): outline initial test scenarios #2672

feat(igxBanner): icon add, #2672

test(igxBanner): fix igxExpansionPanelHeader reference to panel #2672

docs(igxBanner): add public API's descriptions

test(igxBanner): banner initialization and events tests #2672

style(banner) initial styling for banner component

style(banner): change styles for banner

test(igxBanner): custom template banner tests #2672

chore(igxBanner): additional merge

chore(igxBanner): add missing definition in _banner-theme.scss

test(igxBanner): fix some failing test, #2672

chore(igxBanner): remove fdesribe from tests, #2672

test(igxBanner): add some more tests, #2672

feat(igxBanner): implement IToggleView in expansion panel and in banner, #2672

docs(igxBanner): add README.md, #2672

feat(igxBanner): dev sample update, #2672

test(igxBanner): add two more tests, #2672

refactor(igxBanner): refactor banner, tests WIP

refactor(igxBanner): banner implements onOpening, onClosing

chore(igxBanner): fix some banner tests, WIP

chore(igxBanner): fix failing tests, add event tests

chore(*): fix failing test method

style(banner): Fix banner background and duplicated styles

style(banner): Remove the oval shape and the background

style(banner): fix some sizing problems on small resolution

# Conflicts:
#	src/app/app.module.ts
#	src/app/app.routing.ts
#	src/app/routing.ts
ViktorSlavov added a commit that referenced this issue Nov 26, 2018
@ViktorSlavov
feat(igxBanner): remove BrowserModule import from banner, #2672
727c766
ViktorSlavov added a commit that referenced this issue Nov 26, 2018
@ViktorSlavov
feat(igxBanner): remove BrowserModule import from banner, #2672
4cd6616
ViktorSlavov added a commit that referenced this issue Nov 26, 2018
@ViktorSlavov
feat(igxBanner): adding aria-live and aria-hidden to banner template, #…
7dd5b1a 
…2672
damyanpetev added a commit that referenced this issue Nov 30, 2018
@damyanpetev
Merge pull request #2978 from IgniteUI/mvenkov/banner-component-imple…
9f50461 
…mentation

Banner component implementation, #2672
@luiscla27 luiscla27 mentioned this issue Dec 1, 2018
Closed
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
fix(igx-grid): revert row editing styles #2672
c216681
Lipata added a commit that referenced this issue Dec 7, 2018
@Lipata
fix(igx-grid): revert row editing styles #2672
bbbb8b1
@SlavUI SlavUI added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 10, 2018
@StefanIvanov StefanIvanov mentioned this issue Dec 10, 2018
Closed
@zdrawku zdrawku mentioned this issue Dec 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanIvanov StefanIvanov

@bazal4o bazal4o

@wnvko wnvko

Labels
feature ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StefanIvanov @bazal4o @wnvko @SlavUI