Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend DropDown and Combo to support DisplayDensity #2960

Closed
bkulov opened this issue Nov 7, 2018 · 3 comments · Fixed by #5035
Closed

Extend DropDown and Combo to support DisplayDensity #2960

bkulov opened this issue Nov 7, 2018 · 3 comments · Fixed by #5035
Assignees
@simeonoff @desig9stein @ViktorSlavov @DaniMarinov
Labels
display-density dropdown 🛠️ status: in-development Issues and PRs with active development on them version: 7.2.x

Comments

@bkulov
Copy link
Contributor

bkulov commented Nov 7, 2018

Extend DropDown and Combo to support DisplayDensity similar to the input group and the grid.
@ViktorSlavov ViktorSlavov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Nov 12, 2018
@bazal4o bazal4o assigned ViktorSlavov and unassigned bazal4o Nov 12, 2018
ViktorSlavov added a commit that referenced this issue Nov 13, 2018
@ViktorSlavov
feat(igxCombo): combo/dropdown extend DisplayDensityBase, adjust temp…
b24b585 
…late,#2960
ViktorSlavov added a commit that referenced this issue Nov 13, 2018
@ViktorSlavov
feat(igxCombo): add display density to constructors, #2960
1b55a28
@ViktorSlavov ViktorSlavov added 🆕 status: new and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 14, 2018
@ViktorSlavov
Copy link
Contributor

As discussed, we need to further look into if and how exactly combo/drop down items display density will be implemented.
For the time being, we are adding only extending the DisplayDensityBase class in the IgxComboComponent, allowing input of display density and passing it down to the input-group (#2410)

@ViktorSlavov ViktorSlavov mentioned this issue May 21, 2019
Closed
@desig9stein desig9stein added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jun 10, 2019
@DaniMarinov DaniMarinov self-assigned this Jun 10, 2019
desig9stein pushed a commit that referenced this issue Jun 10, 2019
style(drop-down): Aadding classes for different density types
1c2bdd2 
Closes #2960
desig9stein pushed a commit that referenced this issue Jun 10, 2019
style(drop-down): Aadding classes for different density types
c6dccb1 
Closes #2960
@desig9stein desig9stein mentioned this issue Jun 10, 2019
Merged
14 tasks
desig9stein pushed a commit that referenced this issue Jun 10, 2019
style(drop-down): Aadding classes for different density types
616f847 
Closes #2960
@desig9stein desig9stein mentioned this issue Jun 10, 2019
Merged
14 tasks
desig9stein pushed a commit that referenced this issue Jun 10, 2019
style(drop-down): Aadding classes for different density types
837815b 
Closes #2960
@desig9stein desig9stein mentioned this issue Jun 10, 2019
Merged
14 tasks
@DaniMarinov
Copy link

@desig9stein You can find the updated spec here https://github.com/IgniteUI/igniteui-angular/wiki/IgxCombo-(Component)#2-design-and-display-density

@DaniMarinov
Copy link

@desig9stein Find the updated spec for the Dropdown component https://github.com/IgniteUI/igniteui-angular/wiki/DropDown-Specification#2-display-density-design

@radomirchev radomirchev removed the combo label Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

@desig9stein desig9stein

@ViktorSlavov ViktorSlavov

@DaniMarinov DaniMarinov

Labels
display-density dropdown 🛠️ status: in-development Issues and PRs with active development on them version: 7.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(drop-down): Adding classes for different density types IgniteUI/igniteui-angular
7 participants
@bkulov @simeonoff @bazal4o @desig9stein @ViktorSlavov @DaniMarinov @radomirchev