Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When rowEditable is set to true in the grid definition the warning for primary key is logged #5010

Closed
nrobakova opened this issue Jun 6, 2019 · 0 comments · Fixed by #5050
Closed

When rowEditable is set to true in the grid definition the warning for primary key is logged #5010

nrobakova opened this issue Jun 6, 2019 · 0 comments · Fixed by #5050
Assignees
@ViktorSlavov
Labels
🐛 bug Any issue that describes a bug 🔥 severity: high grid: general grid: row-editing ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@nrobakova
Copy link
Contributor

Description

When rowEditable is set to true in the grid definition the warning for primary key is logged

  • igniteui-angular version: 7.3
  • browser: n/a

Steps to reproduce

  1. Open dev sample gridRowEdit
  2. Look at the console

Result

There are 3 warnings:
The grid must have a primaryKey specified when using rowEditable!

Expected result

There should be no warning, because all the grids have PrimaryKey set

Attachments

Attach a sample if available, and screenshots, if applicable.
image
@Lipata Lipata assigned ViktorSlavov and unassigned Lipata Jun 6, 2019
@ViktorSlavov ViktorSlavov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jun 12, 2019
ViktorSlavov added a commit that referenced this issue Jun 12, 2019
@ViktorSlavov
fix(grid): fix row editing warning to show when !primaryKey, #5010
fae1245
ViktorSlavov added a commit that referenced this issue Jun 12, 2019
@ViktorSlavov
fix(grid): fix row editing warning to show when !primaryKey, #5010
e7be078 
# Conflicts:
#	projects/igniteui-angular/src/lib/grids/grid-base.component.ts
This was referenced Jun 12, 2019
Merged
Merged
@ViktorSlavov ViktorSlavov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jun 12, 2019
ViktorSlavov added a commit that referenced this issue Jun 13, 2019
@ViktorSlavov
fix(grid): move row edit warning to crudService.beginRowEdit, #5010
ae2d29e
ViktorSlavov added a commit that referenced this issue Jun 13, 2019
@ViktorSlavov
fix(grid): move row edit warning to crudService.beginRowEdit, #5010
265fa97
ViktorSlavov added a commit that referenced this issue Jun 13, 2019
@ViktorSlavov
test(grid): rework rowEdit/primaryKey warning test, #5010
d125700
ViktorSlavov added a commit that referenced this issue Jun 13, 2019
@ViktorSlavov
test(grid): rework rowEdit/primaryKey warning test, #5010
460732a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorSlavov ViktorSlavov

Labels
🐛 bug Any issue that describes a bug 🔥 severity: high grid: general grid: row-editing ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RowEdit + PrimaryKey warning fix - master IgniteUI/igniteui-angular
3 participants
@Lipata @nrobakova @ViktorSlavov