Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[igx-select] Footer element #5911

Closed
sboykova opened this issue Oct 3, 2019 · 3 comments · Fixed by #6148
Closed

[igx-select] Footer element #5911

sboykova opened this issue Oct 3, 2019 · 3 comments · Fixed by #6148
Assignees
@IvayloG
Labels
select Select component size: M 🧰 feature-request version: 9.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@sboykova
Copy link
Contributor

sboykova commented Oct 3, 2019

Is your feature request related to a problem? Please describe.

I need an element which is always into view when scrolling the select items

Describe the solution you'd like

I want to have a way to define igx-select footer element.

Additional context

image
@StefanIvanov
Copy link
Contributor

Have you considered using the igx-combo as it support header and footer templates?

@sboykova
Copy link
Contributor Author

sboykova commented Oct 7, 2019

igx-combo comes with multiple selection - and we just need the single selection igx-select.

@StefanIvanov
Copy link
Contributor

OK we have discussed with @radomirchev to add the same type of templatable header and footer areas to the igx-select as we have in the combo.
I have added a story at the bottom of dev stories in the spec

@Lipata Lipata assigned IvayloG and unassigned Lipata Oct 7, 2019
@IvayloG IvayloG added the 🛠️ status: in-development Issues and PRs with active development on them label Oct 8, 2019
@Lipata Lipata added version: 9.0.x select Select component labels Oct 21, 2019
IvayloG added a commit that referenced this issue Nov 5, 2019
@IvayloG
chore(d): Update drop-down scrollContainer #5911
8cafff6
IvayloG added a commit that referenced this issue Nov 5, 2019
@IvayloG
chore(select): header/footer implementation #5911
f3c29ba 
Adding Header&Footer Templates.
Rewriting Select positioning strategy.
IvayloG added a commit that referenced this issue Nov 5, 2019
@IvayloG
chore(select): Use base-fit positioning #5911
483b0e6 
Update Dev sample. Comment overflow-y.
IvayloG added a commit that referenced this issue Nov 5, 2019
@IvayloG
feat(select): Update base overlay classes #5911
adf9f59
IvayloG added a commit that referenced this issue Nov 5, 2019
@IvayloG
feat(select): Add select positioning strat #5911
b9237b6
IvayloG added a commit that referenced this issue Nov 5, 2019
@IvayloG
chore(select): Minor comments update #5911
ecd7a5a
IvayloG added a commit that referenced this issue Nov 5, 2019
@IvayloG
feat(select): Prevent header/footer click #5911
558915c
IvayloG added a commit that referenced this issue Nov 5, 2019
@IvayloG
chore(select): Update sample #5911
7daf916
@Lipata Lipata mentioned this issue Nov 5, 2019
Closed
IvayloG added a commit that referenced this issue Nov 6, 2019
@IvayloG
chore(select): Remove mousedown handler #5911
69111d6 
Remove mousedown handler(drop-down-item). it is on the ddl container now
IvayloG added a commit that referenced this issue Nov 8, 2019
@IvayloG
chore(select): Update css class structure #5911
62a3dc0 
Update sample, Cleanup code.
@IvayloG IvayloG mentioned this issue Nov 8, 2019
Merged
14 tasks
IvayloG added a commit that referenced this issue Nov 8, 2019
@IvayloG
test(select): Fix most failing tests #5911
37c1a70
IvayloG added a commit that referenced this issue Nov 11, 2019
@IvayloG
test(select): Add header/footer tests #5911
98ad159
IvayloG added a commit that referenced this issue Nov 12, 2019
@IvayloG
fix(select): Scroll to item -smaller screens #5911
2bdd150
IvayloG added a commit that referenced this issue Nov 12, 2019
@IvayloG
fix(select): Scroll partially visible item #5911
a993d94
IvayloG added a commit that referenced this issue Nov 12, 2019
@IvayloG
chore(select): Address comments-5 #5911
5790778
IvayloG added a commit that referenced this issue Nov 12, 2019
@IvayloG
chore(select): Address comments-6 #5911
41f1d5f
IvayloG added a commit that referenced this issue Nov 12, 2019
@IvayloG
chore(select): Update changelog #5911
d72d2e9
IvayloG added a commit that referenced this issue Nov 12, 2019
@IvayloG
chore(select): merge master #5911
32ef74b
IvayloG added a commit that referenced this issue Nov 13, 2019
@IvayloG
chore(select): Update readme #5911
17f412f
@IvayloG IvayloG added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 13, 2019
IvayloG added a commit that referenced this issue Nov 13, 2019
@IvayloG
chore(select): Add methods descriptions #5911
e627216
@IvayloG IvayloG added 🛠️ status: in-development Issues and PRs with active development on them and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Nov 13, 2019
IvayloG added a commit that referenced this issue Nov 19, 2019
@IvayloG
chore(select): Address comments #5911
8571f47
IvayloG added a commit that referenced this issue Nov 19, 2019
@IvayloG
chore(test): Remove fdescribe #5911
d25babc
IvayloG added a commit that referenced this issue Nov 19, 2019
@IvayloG
fix(select): Fix reposition on window scroll #5911
aecfd4d
IvayloG added a commit that referenced this issue Nov 20, 2019
@IvayloG
fix(select): Implement possitioning cases #5911
06bd523
IvayloG added a commit that referenced this issue Nov 20, 2019
@IvayloG
fix(select): Fix last items positioning #5911
541e299
IvayloG added a commit that referenced this issue Nov 20, 2019
@IvayloG
fix(select): Floor verticalFit/horizontalFit #5911
ed9cedb
IvayloG added a commit that referenced this issue Nov 21, 2019
@IvayloG
chore(select): Address comments #5911
94aff4e
IvayloG added a commit that referenced this issue Nov 21, 2019
@IvayloG
chore(select): minor refactoring #5911
3086688
@Lipata Lipata added 💥 status: in-test PRs currently being tested ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them 💥 status: in-test PRs currently being tested labels Nov 21, 2019
IvayloG added a commit that referenced this issue Nov 21, 2019
@IvayloG
test(select): Fix auto-pos tests #5911
760d491
IvayloG added a commit that referenced this issue Nov 21, 2019
@IvayloG
chore(select): Math round #5911
cf6a267
IvayloG added a commit that referenced this issue Nov 22, 2019
@IvayloG
test(select): Cover missed scenarios #5911
47e5dc5
Lipata pushed a commit that referenced this issue Nov 22, 2019
@IvayloG @Lipata
feat(select): implement header & footer; refactor #5911 (#6148)
eae44e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvayloG IvayloG

Labels
select Select component size: M 🧰 feature-request version: 9.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[igx-select] Implement select header & footer. IgniteUI/igniteui-angular
5 participants
@StefanIvanov @Lipata @IvayloG @sboykova @radomirchev