Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgxDatePicker refactoring #6483

Closed
jackofdiamond5 opened this issue Jan 16, 2020 · 3 comments · Fixed by #9160
Closed

IgxDatePicker refactoring #6483

jackofdiamond5 opened this issue Jan 16, 2020 · 3 comments · Fixed by #9160
Assignees
Labels
📈 enhancement 📅 date-picker program: igniteui project management refactoring ♿ a11y When the issue or PR is related to accessibility ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@jackofdiamond5
Copy link
Member

jackofdiamond5 commented Jan 16, 2020

Dependant on #6271

Related to #7199

Specification

With the new IgxDateTimeEditorDirective implemented, we should refactor the IgxDatePicker to use the new editor to handle mask parsing, spinning, date validation and any other action related to the date picker's input.

Tasks during refactoring:

  • Inheritance of new base parent - introducing new members, renaming old ones (1 day)
  • Integration of IgxDateTimeEditorDirective (10 days)
    • Code clean up for already existing functionality in the IgxDatePickerComponent
    • Refactoring of model binding
    • Move CalendarContainer to global date directory
  • Have IgxDateRangePickerComponent extend PickersBaseDirective (2 days)

  • Refactoring of DatePickerUtils - will be renamed to DateTimeUtils (4 days)

    • Unit tests for DateTimeUtils's public methods

Current estimations are purely for development time.

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jun 23, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Jun 23, 2020
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 23, 2020
@jackofdiamond5 jackofdiamond5 removed the status: inactive Used to stale issues and pull requests label Aug 24, 2020
@radomirchev
Copy link
Contributor

Closes #6286

@kdinev kdinev added the ♿ a11y When the issue or PR is related to accessibility label Feb 10, 2021
@Lipata Lipata mentioned this issue Mar 16, 2021
14 tasks
@jackofdiamond5 jackofdiamond5 added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 31, 2021
Lipata added a commit that referenced this issue Apr 19, 2021
, #6483 (#9319)

Co-authored-by: Boris <jackofdiamond596@gmail.com>
Co-authored-by: plamenamiteva <plamenamiteva@abv.bg>
Lipata pushed a commit that referenced this issue Apr 21, 2021
…#6483 (#9160)

* feat(*): add PickersBaseDirective

* feat(date-time-editor): handling for wheel events

* feat(types): add new enum HeaderOrientation

* feat(date-time-editor): add preventSpeenOnWheel input

* feat(date-time-editor): can be set to suppress focus

* feat(DatePickerUtils): add method for min/max validation

* refactor(CalendarContainer): move to date-utils

* feat(PickersBaseDirective): implements EditorProvider

* refactor(picker-icons): move picker icon components to date-common

* feat(date-time-editor): add option to set spin delta per part #7169 (#8987)

* refactor(date-range): pickers base, overlay service, template buttons, valueChange

* refactor(date-editor): rename isSpinLoop to spinLoop

* feat(date-time-editor, date-range-picker, date-picker): ISO 8601 support #6994

* feat(date-picker): add readonly prop, close on escape

* refactor(advanced-filtering): update date picker template

* refactor(filtering-row): update date picker template

* refactor(excel-style-date-expr): update date picker template

* refactor(input-directive):  set disabled using hostbinding

* feat(igx-time-picker): refactoring #6482 (#8947)

* feat(date-time-editor, pickers): add migrations, changelog, readme #6482, #6483 (#9319)

Co-authored-by: Boris <jackofdiamond596@gmail.com>
Co-authored-by: plamenamiteva <plamenamiteva@abv.bg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 enhancement 📅 date-picker program: igniteui project management refactoring ♿ a11y When the issue or PR is related to accessibility ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants